Re: [Xen-devel] [PATCH 6/6] xen/sched: don't disable scheduler on cpus during suspend

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Mon, 2019-03-18 at 14:11 +0100, Juergen Gross wrote:
> Today there is special handling in cpu_disable_scheduler() for
> suspend
> by forcing all vcpus to the boot cpu. In fact there is no need for
> that
> as during resume the vcpus are put on the correct cpus again.
> 
> So we can just omit the call of cpu_disable_scheduler() when
> offlining
> a cpu due to suspend and on resuming we can omit taking the schedule
> lock for selecting the new processor.
> 
> In restore_vcpu_affinity() we should be careful when applying
> affinity
> as the cpu might not have come back to life. This in turn enables us
> to even support affinity_broken across suspend/resume.
> 
> Avoid all other scheduler dealloc - alloc dance when doing suspend
> and
> resume, too. It is enough to react on cpus failing to come up on
> resume
> again.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
Ok, I think this patch is fine.

Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>

I guess you have tested both cpu off/on-lining and suspend/resume, or
do you need help with that? (One of my testboxes that I have here,
should be able to do suspend)

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel