|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86emul/fuzz: adjust canonicalization in sanitize_input()
>>> On 29.03.19 at 16:14, <George.Dunlap@xxxxxxxxxx> wrote: > >> On Mar 29, 2019, at 2:51 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote: >> >> Drop it entirely for %rbp - this register is not special purpose enough >> to warrant such special treatment. Add a comment to clarify the purpose >> of the canonicalization of %rip and %rsp. >> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > > FAOD: > 1. I don’t oppose this, but > 2. I don’t support it either; however, > 3. I don’t think my Ack is necessary. Well, preferably I would address your concerns despite 3. So could you clarify what you would suggest instead? Keep things as they are? Drop all canonicalization? I've basically tried to find a middle ground between the two extremes. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |