Re: [Xen-devel] [PATCH v2 1/1] hvmloader: add SMBIOS type 2 info for customized string

["Xin Li (Talons)" <xin.li@xxxxxxxxxx>]

> So this is the 3rd variant of v2 that you've sent, without making it clear
> what the difference is. I suppose you've addressed my one remaining
> cosmetic request and added my R-b, but we should be at v4 then.

Yes. Since these are all style change, I kept the version number 2.
Sorry for the confusion.

Kind Regards

Xin(Talons)

________________________________________
From: Jan Beulich <JBeulich@xxxxxxxx>
Sent: Friday, March 29, 2019 7:08 PM
To: Xin Li
Cc: Andrew Cooper; Igor Druzhinin; Sergey Dyasli; Xin Li (Talons); 
xen-devel@xxxxxxxxxxxxx
Subject: Re: [PATCH v2 1/1] hvmloader: add SMBIOS type 2 info for customized 
string

>>> On 29.03.19 at 04:28, <talons.lee@xxxxxxxxx> wrote:
> Extend smbios type 2 struct to match specification, add support to
> write it when customized string provided and no smbios passed in.
>
> Signed-off-by: Xin Li <xin.li@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> CC: Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> v2
> 1: write the struct if any of the strings is provided
> 2: add contained_handles as flexible array member
> 3: update commit message and fix style issue

So this is the 3rd variant of v2 that you've sent, without making it clear
what the difference is. I suppose you've addressed my one remaining
cosmetic request and added my R-b, but we should be at v4 then.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel