[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 08/49] xen/sched: use new sched_item instead of vcpu in scheduler interfaces



On Mon, 2019-04-01 at 08:06 +0200, Juergen Gross wrote:
> On 30/03/2019 11:24, Juergen Gross wrote:
> > I think its is easier to do it myself, as I'm touching nearly all
> > of
> > the call sites anyway.
> 
> And another thought I had: with RETPOLINE indirect jumps are even
> more
> expensive. Would it be a good idea to remove the function pointers
> from
> struct scheduler and generate the inline wrappers at build time?
>
Yep, I was thinking about doing something like that already,
independently from this feature/series.

At least something that special case the configured default scheduler,
and let its hooks be called without indirect jumps (i.e., similarly to
what's being done in Linux, in quite a few places, these days).

> The
> wrappers could then call the related specific scheduler function
> based
> on the scheduler Id using a chain of if ... else if ... statements. 
>
I guess we'd have to see how the final code will look, but I like the
idea, and I think it's well worth a try.

Regards,
Dario
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.