Re: [Xen-devel] [PATCH v2 1/6] xen/sched: call cpu_disable_scheduler() via cpu notifier

[Julien Grall <julien.grall@xxxxxxx>]

Hi Juergen,

On 3/28/19 12:06 PM, Juergen Gross wrote:
> cpu_disable_scheduler() is being called from __cpu_disable() today.
> There is no need to execute it on the cpu just being disabled, so use
> the CPU_DEAD case of the cpu notifier chain. Moving the call out of
> stop_machine() context is fine, as we just need to hold the domain RCU
> lock and need the scheduler percpu data to be still allocated.
>
> Add another hook for CPU_DOWN_PREPARE to bail out early in case
> cpu_disable_scheduler() would fail. This will avoid crashes in rare
> cases for cpu hotplug or suspend.
>
> While at it remove a superfluous smp_mb() in the ARM __cpu_disable()
> incarnation.
Can we avoid sending the same patches in the different series in just a 
day interval? This is making difficult to know which one to review...
It would be easier if you tell in the cover letter that you depend on 
series Foo and provide a branch with the two series in applied.
Anyway, I have commented on <20190329150934.17694-2-jgross@xxxxxxxx>.


Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel