Re: [Xen-devel] [PATCH v1] x86/microcode: always collect_cpu_info() during boot

[Chao Gao <chao.gao@xxxxxxxxx>]

On Mon, Apr 01, 2019 at 11:19:19AM +0100, Sergey Dyasli wrote:
>On 25/03/2019 17:08, Jan Beulich wrote:
>>>>> On 25.03.19 at 12:12, <sergey.dyasli@xxxxxxxxxx> wrote:
>>> Currently cpu_sig struct is not updated during boot when either:
>>>
>>>     1. ucode_scan is set to false (e.g. no "ucode=scan" in cmdline)
>>>     2. initrd does not contain a microcode blob
>> 
>> What about "ucode=<number>"?
>
>Yes, it's equally affected, I'll update the commit message.
>
>>> These will result in cpu_sig.rev being 0 which affects APIC's
>>> check_deadline_errata() and retpoline_safe() functions.
>>>
>>> Fix this by getting ucode revision early during boot and SMP bring up.
>> 
>> Can't you then drop the call from microcode_update_cpu()?
>
>I tried this and found that properly handling errors requires
>a call to __microcode_fini_cpu(). But instead of doing all this
>refactoring now, I'd prefer this patch to go on top of Chao's
>series, which greatly simplifies things in "remove struct
>ucode_cpu_info". Otherwise, most of my work here would be removed
>by the next version of Chao's series.
>
>Chao,
>To help me with this decision, when can we expect a v7 of your
>series?

Will start to work on v7 from tomorrow. And I hope that it will be finished
in this week.

Thanks
Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel