Re: [Xen-devel] [PATCH v2 1/2] xen: add interface for obtaining .config from hypervisor

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Mar 15, 2019 at 05:29:28PM +0100, Juergen Gross wrote:
> On 15/03/2019 16:55, Andrew Cooper wrote:
> > On 14/03/2019 11:59, Juergen Gross wrote:
> >> @@ -1100,6 +1100,20 @@ typedef struct xen_sysctl_cpu_policy 
> >> xen_sysctl_cpu_policy_t;
> >>  DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t);
> >>  #endif
> >>  
> >> +/*
> >> + * XEN_SYSCTL_get_config
> >> + *
> >> + * Return gzip-ed .config file
> > 
> > I don't think it is wise to bake gzip into the API.  These days, there
> > really are better options than gzip both in terms of compression ratio
> > and decompress speed.
> > 
> > I'd suggest just saying "file may be compressed" and leave it up to the
> > packagers build system and `xl` choices to agree on which compression
> > (if any) to use.
> 
> I am not convinced this is a good idea. I think the data format should
> be specified.
> 
> And TBH: the difference in size for a rather "normal" .config is about
> 50 bytes (I tried gzip, xz and bzip2 with gzip producing the smallest
> result).

Has this been resolved?

I don't really have an opinion on this.

Wei.

> 
> 
> Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel