Xen project Mailing List

Re: [Xen-devel] [PATCH v5 00/15] Add support for Hygon Dhyana Family 18h processor

Hi,

I am not sure why I end up to be CCed on the cover letter when I am not CCed on

the rest of series.

Cheers, On 04/04/2019 14:44, Pu Wen wrote:

As a new x86 CPU vendor, Chengdu Haiguang IC Design Co., Ltd (Hygon)
is a joint venture between AMD and Haiguang Information Technology Co.,
Ltd., aims at providing high performance x86 processors for China
server market.

The first generation Hygon processor(Dhyana) originates from AMD
technology and shares most of the architecture with AMD's family 17h,
but with different CPU vendor ID("HygonGenuine") and family series
number 18h (Hygon negotiated with AMD to make sure that only Hygon
will use family 18h).

To enable support of Xen to Hygon Dhyana CPU, add a new vendor type
(X86_VENDOR_HYGON, with value of 5), and share most of the code with
AMD family 17h.

The MSRs and CPUIDs which are used by this patch series are all defined
in this PPR[1].

This patch series have been applied and tested successfully on Hygon
Dhyana processor, also been tested on AMD EPYC (family 17h) processor.
It works fine and makes no harm to the existing code.

Reference:
[1] 
https://www.amd.com/system/files/TechDocs/54945_PPR_Family_17h_Models_00h-0Fh.pdf


v4->v5:
   - Rebased over https://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=0763cd26
     to fit the new x86 vendor lookup mechanism.
   - Rework patch 15/15 to fit the new x86 vendor lookup mechanism.
   - Add Acked-by from Jan Beulich for patch 02/15 and 04/15.
   - Retain more conditionals from amd.c.
   - Refine coding style.

v3->v4:
   - Revert opt_cpuid_mask_l7s0_(eax/ebx) to amd.c.
   - Create a separate patch to fix common cpuid faulting probing issue
     for AMD and Hygon.
   - Rename _vpmu_init() to common_init() and move the default case into it.
   - Coding style refine.

v2->v3:
   - Rebased on 4.13-unstable and tested against it.
   - Simplify code of hygon.c by re-using early_init_amd().
   - Return false in the function probe_cpuid_faulting().
   - Adjust code for calculating phys_proc_id for Hygon.
   - Abstract common function _vpmu_init() and add hygon_vpmu_init().
   - Refine some comments and descriptions.
   - Add Acked-by from Jan Beulich for x86/cpu/mtrr, x86/cpu/mce,
     x86/spec_ctrl, x86/apic, x86/acpi, x86/iommu, x86/pv, x86/domain,
     x86/domctl and x86/cpuid.

v1->v2:
   - Rebased on 4.12.0-rc3 and tested against it.
   - Move opt_cpuid_mask_l7s0_(eax/ebx) to common.c.
   - Insert Hygon cases after AMD ones instead of above.
   - Remove (rd/wr)msr_hygon_safe and use (rd/wr)msr_safe instead.
   - Remove wrmsr_hygon and use wrmsrl instead.
   - Remove the unnecessary change to xstate.
   - Refine some codes and comments.
   - Add Acked-by from Jan Beulich for x86/traps.
   - Add Acked-by from Wei Liu for tools/libxc.


Pu Wen (15):
   x86/cpu: Create Hygon Dhyana architecture support file
   x86/cpu: Fix common cpuid faulting probing for AMD and Hygon
   x86/cpu/mtrr: Add Hygon Dhyana support to get TOP_MEM2
   x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU
   x86/cpu/mce: Add Hygon Dhyana support to the MCA infrastructure
   x86/spec_ctrl: Add Hygon Dhyana to the respective mitigation machinery
   x86/apic: Add Hygon Dhyana support
   x86/acpi: Add Hygon Dhyana support
   x86/iommu: Add Hygon Dhyana support
   x86/pv: Add Hygon Dhyana support to emulate MSRs access
   x86/domain: Add Hygon Dhyana support
   x86/domctl: Add Hygon Dhyana support
   x86/traps: Add Hygon Dhyana support
   x86/cpuid: Add Hygon Dhyana support
   tools/libxc: Add Hygon Dhyana support

  tools/libxc/xc_cpuid_x86.c             |  11 ++--
  xen/arch/x86/acpi/cpu_idle.c           |   3 +-
  xen/arch/x86/acpi/cpufreq/cpufreq.c    |   8 ++-
  xen/arch/x86/acpi/cpufreq/powernow.c   |   3 +-
  xen/arch/x86/apic.c                    |   5 ++
  xen/arch/x86/cpu/Makefile              |   1 +
  xen/arch/x86/cpu/amd.c                 |   2 +-
  xen/arch/x86/cpu/common.c              |   9 ++-
  xen/arch/x86/cpu/cpu.h                 |   3 +
  xen/arch/x86/cpu/hygon.c               | 114 +++++++++++++++++++++++++++++++++
  xen/arch/x86/cpu/mcheck/amd_nonfatal.c |   5 +-
  xen/arch/x86/cpu/mcheck/mce.c          |   6 +-
  xen/arch/x86/cpu/mcheck/mce_amd.c      |   5 +-
  xen/arch/x86/cpu/mcheck/non-fatal.c    |   3 +-
  xen/arch/x86/cpu/mcheck/vmce.c         |   2 +
  xen/arch/x86/cpu/mtrr/generic.c        |   5 +-
  xen/arch/x86/cpu/vpmu.c                |   8 +++
  xen/arch/x86/cpu/vpmu_amd.c            |  61 ++++++++++++------
  xen/arch/x86/cpuid.c                   |  10 ++-
  xen/arch/x86/dom0_build.c              |   3 +-
  xen/arch/x86/domain.c                  |   9 +--
  xen/arch/x86/domctl.c                  |  13 +++-
  xen/arch/x86/pv/emul-priv-op.c         |  19 ++++--
  xen/arch/x86/spec_ctrl.c               |   6 +-
  xen/arch/x86/traps.c                   |   3 +
  xen/include/asm-x86/iommu.h            |   1 +
  xen/include/asm-x86/vpmu.h             |   1 +
  xen/include/asm-x86/x86-vendors.h      |   7 +-
  xen/lib/x86/cpuid.c                    |   6 ++
  29 files changed, 275 insertions(+), 57 deletions(-)
  create mode 100644 xen/arch/x86/cpu/hygon.c

-- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.