[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] vm_event: Fix XEN_VM_EVENT_RESUME domctl



>>> On 05.04.19 at 11:33, <ppircalabu@xxxxxxxxxxxxxxx> wrote:
> @@ -529,30 +534,21 @@ int __vm_event_claim_slot(struct domain *d, struct 
> vm_event_domain *ved,
>  /* Registered with Xen-bound event channel for incoming notifications. */
>  static void mem_paging_notification(struct vcpu *v, unsigned int port)
>  {
> -    struct domain *domain = v->domain;
> -
> -    if ( likely(vm_event_check_ring(domain->vm_event_paging)) )
> -        vm_event_resume(domain, domain->vm_event_paging);
> +    (void)vm_event_resume(v->domain, v->domain->vm_event_paging);

Unless there's a good reason for them, could you please avoid
adding such casts?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.