Re: [Xen-devel] [PATCH v4 1/4] x86: stop handling MSR_IA32_BNDCFGS save/restore in implementation code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.03.19 at 14:51, <paul.durrant@xxxxxxxxxx> wrote:
> Saving and restoring the value of this MSR is currently handled by
> implementation-specific code despite it being architectural. This patch
> moves handling of accesses to this MSR from hvm.c into the msr.c, thus
> allowing the common MSR save/restore code to handle it.
> 
> NOTE: Because vmx_get/set_guest_bndcfgs() call vmx_vmcs_enter(), the
>       struct vcpu pointer passed in, and hence the vcpu pointer passed to
>       guest_rdmsr() cannot be const.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
> Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>
> 
> v4:
>  - Cosmetic re-arrangements and an additional ASSERT requested by Jan
> 
> v3:
>  - Address further comments from Jan
>  - Dropped Kevin's R-b because of change to vmx.c

Kevin,

you may not have noticed the above.

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel