Re: [Xen-devel] [PATCH for-next] xen/arm: irq: Don't use _IRQ_PENDING when handling host interrupt

[Julien Grall <julien.grall@xxxxxxx>]

On 05/04/2019 15:16, Andrii Anisov wrote:
> On 28.01.19 17:59, Julien Grall wrote:
> > While SPIs are shared between CPU, it is not possible to receive the
> > same interrupts on a different CPU while the interrupt is in active
> > state. The deactivation of the interrupt is done at the end of the
> > handling.
> >
> > This means the _IRQ_PENDING logic is unecessary on Arm as a same
> > interrupt can never come up while in the loop. So remove it to
> > simplify the interrupt handle code.
> What about _IRQ_PENDING macro itself?
> Any reasons to not eliminate it?
It is in common header and used by x86. It is preferable to keep all IRQ flags 
at the same place hence why this was not moved in arch-specific header.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel