Re: [Xen-devel] [PATCH] common/gnttab: Process softirqs while dumping grant tables

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.04.19 at 18:33, <andrew.cooper3@xxxxxxxxxx> wrote:
> OSSTests upgrade to Jessie has identified that with a sufficiently large grant
> table, a watchdog timeout can occur.

How's this dependent on the precise distro version? I.e. is there
something that makes the logging slower now?

> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -3956,6 +3956,9 @@ static void gnttab_usage_print(struct domain *rd)
>          uint16_t status;
>          uint64_t frame;
>  
> +        if ( !(ref & 31) )
> +            process_pending_softirqs();

I think this is both risky and overly eager: Risky because of happening
with a lock held, and overly eager because no output may have been
done at all between any two such calls. That notwithstanding
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
on the basis that it is an improvement, and the risk is - afaict - a latent
one only.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel