Re: [Xen-devel] [edk2-devel] [PATCH v2 01/31] OvmfPkg/ResetSystemLib: Add missing dependency on PciLib

[Laszlo Ersek <lersek@xxxxxxxxxx>]

On 04/09/19 13:08, Anthony PERARD wrote:
> and remove extra includes of OvmfPlatforms.h.

(1) In commit messages, please don't rely on the subject line, and the
first paragraph of the body, being read as a single sentence.
(Similarly, please avoid empy commit message bodies.) If there's no
better way to prevent this, then just repeat the subject line in te
first paragraph.

I realize this is subjective & project dependent; it's certainly my
preference, but I recall other reviewers requesting the same on edk2-devel.

> 
> Contributed-under: TianoCore Contribution Agreement 1.1

(2) Please drop this line from all the commit messages:
<https://bugzilla.tianocore.org/show_bug.cgi?id=1655#c0>.

> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> 
> Notes:
>     v2:
>     - also add PciLib.h include to the .c
>     - and remove extra include of OvmfPlatforms.h
> 
>  OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 1 +
>  OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c   | 3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf 
> b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> index 39ca805730..ebd722e66b 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> @@ -36,4 +36,5 @@ [Packages]
>  [LibraryClasses]
>    DebugLib
>    IoLib
> +  PciLib
>    TimerLib
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c 
> b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> index cc75d046a8..9348502836 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -17,11 +17,10 @@
>  #include <Library/BaseLib.h>
>  #include <Library/DebugLib.h>
>  #include <Library/IoLib.h>
> +#include <Library/PciLib.h>
>  #include <Library/TimerLib.h>
>  #include <OvmfPlatforms.h>
>  
> -#include <OvmfPlatforms.h>
> -
>  VOID
>  AcpiPmControl (
>    UINTN SuspendType
> 

Hm, the duplicated #include is my fault, from commit 1466b76f9385
("OvmfPkg: determine PMBA value dependent on host bridge device ID",
2016-05-17). Thanks for fixing that up.

Reviewed-by: Laszlo Ersek <lersek@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel