[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [OSSTEST PATCH 52/62] target_install_packages: Consistently use qw(...) rather than '...'
qw(...) splits its argument into words. There is one semantic change, where two package names were passed in a single argument. That worked by accident. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> --- ts-xen-install | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ts-xen-install b/ts-xen-install index 80952857..03f8c03e 100755 --- a/ts-xen-install +++ b/ts-xen-install @@ -53,18 +53,18 @@ sub packages () { qemu-utils netcat-openbsd)); if ($ho->{Suite} !~ m/squeeze|wheezy|jessie/) { - target_install_packages($ho, 'net-tools libnl-route-3-200'); + target_install_packages($ho, qw(net-tools libnl-route-3-200)); } if ($ho->{Suite} =~ m/jessie/) { - target_install_packages($ho, 'libnl-route-3-200'); + target_install_packages($ho, qw(libnl-route-3-200)); } target_install_packages($ho, $ho->{Suite} =~ /squeeze/ ? "libyajl1" : "libyajl2"); if ($ho->{Suite} !~ m/lenny|squeeze/) { - target_install_packages($ho, 'libfdt1'); + target_install_packages($ho, qw(libfdt1)); } if ($r{arch} eq 'i386') { - target_install_packages($ho, 'libc6-xen'); + target_install_packages($ho, qw(libc6-xen)); } target_install_packages($ho, @{toolstack($ho)->{ExtraPackages}}) if toolstack($ho)->{ExtraPackages}; @@ -88,7 +88,7 @@ sub some_extradebs ($) { $ontarget = "extrapackages-$cfgvar-$counter"; $counter++; $dpkgopts = '-iGROEB'; logm("$cfgvar: updating packages from directory $path"); - target_install_packages($ho, 'rsync') unless $rsync_installed++; + target_install_packages($ho, qw(rsync)) unless $rsync_installed++; target_putfile_root($ho,300, "$path/.", $ontarget, '-r'); } elsif ($path =~ m{\.deb$}) { $path =~ s{_\.deb}{ "_$r{arch}.deb" }e; -- 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |