Re: [Xen-devel] [PATCH 2/2] RFC: x86/mm: conditionally check page_lock/page_unlock ownership

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.04.19 at 06:29, <tamas@xxxxxxxxxxxxx> wrote:
> Patch cf4b30dca0a "Add debug code to detect illegal page_lock and 
> put_page_type
> ordering" added extra sanity checking to page_lock/page_unlock for debug 
> builds
> with the assumption that no hypervisor path ever locks two pages at once.
> 
> This assumption doesn't hold during memory sharing.

A fundamental question is - doesn't mem-sharing abuse page_lock()?
I've never understood why it uses it, and back when it was introduced
the function clearly wasn't meant to be used outside of PV memory
management code.

One minimal remark on the patch itself: Please use true/false instead
of 1/0 when passing bool arguments.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel