[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3 3/5] xen/arm: drivers: scif: Add support for SCIFA compatible UARTs



Hi Olekansdr,

On 4/8/19 11:14 AM, Oleksandr Tyshchenko wrote:
diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c
index 958f717..94cb230 100644
--- a/xen/drivers/char/scif-uart.c
+++ b/xen/drivers/char/scif-uart.c
@@ -1,7 +1,7 @@
  /*
   * xen/drivers/char/scif-uart.c
   *
- * Driver for SCIF (Serial communication interface with FIFO)
+ * Driver for SCIF(A) (Serial communication interface with FIFO (A))
   * compatible UART.
   *
   * Oleksandr Tyshchenko <oleksandr.tyshchenko@xxxxxxxxxxxxxxx>
@@ -46,6 +46,7 @@ static struct scif_uart {
  enum port_types
  {
      SCIF_PORT,
+    SCIFA_PORT,
      NR_PORTS,
  };
@@ -74,6 +75,20 @@ static const struct port_params port_params[NR_PORTS] =
          .irq_flags    = SCSCR_RIE | SCSCR_TIE | SCSCR_REIE,
          .fifo_size    = 16,
      },
+
+    [SCIFA_PORT] =
+    {
+        .status_reg   = SCIFA_SCASSR,
+        .tx_fifo_reg  = SCIFA_SCAFTDR,
+        .rx_fifo_reg  = SCIFA_SCAFRDR,
+        .overrun_reg  = SCIFA_SCASSR,
+        .overrun_mask = SCASSR_ORER,

As mentioned in patch #2, overrun_mask will never be used here. Can you please confirm whether this is intended?

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.