Re: [Xen-devel] [PATCH V3 4/5] xen/arm: Extend SCIF early prink code to handle other interfaces

[Oleksandr <olekstysh@xxxxxxxxx>]

On 14.04.19 20:48, Julien Grall wrote:
> Hi,
Hi Julien


> On 4/8/19 11:14 AM, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> >
> > Extend early prink code to be able to handle other SCIF(X)
> > compatible interfaces as well. These interfaces have lot in common,
> > but mostly differ in offsets and bits for some registers.
> >
> > Introduce "EARLY_PRINTK_VERSION" config option to choose which
> > interface version should be used (to properly apply register offsets).
> >
> > Please note, nothing has been technically changed for Renesas "Lager"
> > and other supported boards (SCIF).
> >
> > The "EARLY_PRINTK_VERSION" option for that board should be empty:
> > CONFIG_EARLY_PRINTK=scif,0xe6e60000
> >
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> > CC: Julien Grall <julien.grall@xxxxxxx>
> >
> > ---
> >      Changes in v3:
> >          - It was decided not to introduce new debug-scifa.inc
> >            for handling SCIFA interface, but to extend existing
> >            debug-scif.inc for handling both interfaces.
> >            This patch is a result of splitting an initial patch
> >            "xen/arm: Add SCIFA UART support for early printk"
> >            and only reworks a code
> > ---
> >   xen/arch/arm/Rules.mk             |  7 +++++++
> >   xen/arch/arm/arm32/debug-scif.inc | 13 +++++++++----
> You want to update docs/misc/arm/early-printk.txt with the new option.
Sure, will update.


> Otherwise, the code looks good to me.
>
> Cheers,
--
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel