Re: [Xen-devel] [PATCH v4] x86/mm: Aggregate get entry and populate into common funcs

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx> 04/15/19 11:23 AM >>>
>--- a/xen/include/asm-x86/p2m.h
>+++ b/xen/include/asm-x86/p2m.h
>@@ -514,6 +514,23 @@ static inline unsigned long mfn_to_gfn(struct domain *d, 
>mfn_t mfn)
         >return mfn_x(mfn);
>}
 >
>+int get_altp2m_entry(struct p2m_domain *ap2m, gfn_t gfn, mfn_t *mfn,
>+                     p2m_type_t *t, p2m_access_t *a, bool prepopulate);
>+
>+static inline int altp2m_get_entry_direct(struct p2m_domain *ap2m,
>+                                              gfn_t gfn, mfn_t *mfn,
>+                                              p2m_type_t *t, p2m_access_t *a)
>+{
>+    return get_altp2m_entry(ap2m, gfn, mfn, t, a, false);
>+}
>+
>+static inline int altp2m_get_entry_prepopulate(struct p2m_domain *ap2m,
>+                                               gfn_t gfn, mfn_t *mfn,
>+                                               p2m_type_t *t, p2m_access_t *a)
>+{
>+    return get_altp2m_entry(ap2m, gfn, mfn, t, a, true);
>+}

The worker function name would imo better be altp2m_get_entry(), then in line
with its two wrappers.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel