Re: [Xen-devel] [PATCH] golang/xenlight: Fixing compilation for go 1.11

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Sat, Apr 20, 2019 at 07:27:55PM -0400, Daniel P. Smith wrote:
> On 4/18/19 9:11 AM, George Dunlap wrote:
> > On 4/18/19 2:52 AM, Daniel P. Smith wrote:
> >> This deals with two casting issues for compiling under go 1.11:
> >> - explicitly cast to *C.xentoollog_logger for Ctx.logger pointer
> >> - add cast to unsafe.Pointer for the C string cpath
> >>
> >> Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> > 
> > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> > 
> > BTW, do you know if this will compile for older versions of go?
> 
> Per the suggestion on IRC, I did a test compile with golang 1.10.8 as
> the version available with Ubuntu 18.04 was 1.10.1. Since this matters,
> the environment was setup with Xen 4.12 tools. If there are additional
> variations you would like to see, please let me know as I am using a
> docker container setup for reproducible build environments and should be
> able to spin up different variations fairly easily.
>

Ubuntu 16.04 LTS seems to ship golang 1.6 as a default.

CentOS7 used to ship golang 1.9 in CentOS 7.5 and earlier (in extras repo), but 
currently in CentOS 7.6+ has golang 1.10 (in SCL) and 1.11 (in epel) available.


Thanks,

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel