Re: [Xen-devel] [PATCH v2] x86/msr: Fix fallout from mostly c/s 832c180

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: Monday, April 15, 2019 8:03 PM
> 
>  * Fix the shim build by providing a !CONFIG_HVM declaration for
>    hvm_get_guest_bndcfgs(), and removing the introduced
>    ASSERT(is_hvm_domain(d))'s.  They are needed for DCE to keep the build
>    working.  Furthermore, in this way, the risk of runtime type confusion is
>    removed.
>  * Revert the de-const'ing of the vcpu pointer in vmx_get_guest_bndcfgs().
>    vmx_vmcs_enter() really does mutate the vcpu, and may cause it to undergo
> a
>    full de/reschedule, which is in violation of the ABI described by
>    hvm_get_guest_bndcfgs().  guest_rdmsr() was always going to need to lose
>    its const parameter, and this was the correct time for it to happen.
>  * The MSRs in vcpu_msrs are in numeric order.  Re-position XSS to match.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel