Re: [Xen-devel] [PATCH] livepatch-build-tools: Detect special section group sizes

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Apr 16, 2019 at 11:05:49AM +0100, Ross Lagerwall wrote:
> On 4/12/19 5:50 AM, Glenn Enright wrote:
> > A recent xsa livepatch failed to generate due to the following
> > message in create-diff-object.log ...
> > 
> > /livepatch-build-tools/create-diff-object: ERROR: grant_table.o:
> > kpatch_regenerate_special_section: 1162: group size mismatch for section
> > .altinstructions
> > 
> > This is similar to the issue reported and fixed in
> > https://github.com/dynup/kpatch/pull/528 which says ...
> > "Hard-coding the special section group sizes is unreliable.
> >   Instead, determine them dynamically by finding the related
> >   struct definitions in the DWARF metadata."
> > 
> > Signed-off-by: Glenn Enright <glenn@xxxxxxxxxxxxxxx>
> > ---
> > CC: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> > CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > 
> > This patch resulted in a loadable livepatch. The alt section size in my
> > case was actually 14.
> Thanks for the patch!
> 
> Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Could you resend it with the Reviewed-by please and include me on the To list 
please?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel