Re: [Xen-devel] [PATCH 2/2 v2] x86/acpi: Improve suspend and resume process for Zhaoxin CPU

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.04.19 at 10:50, <fionali-oc@xxxxxxxxxxx> wrote:
> When executing SYSEXIT or SYSENTRY in Zhaoxin CPU, CPU needs to

SYSENTER

> --- a/xen/arch/x86/x86_64/traps.c
> +++ b/xen/arch/x86/x86_64/traps.c
> @@ -334,7 +334,8 @@ void subarch_percpu_traps_init(void)
>                                     (unsigned long)lstar_enter);
>      stub_va += offset;
>  
> -    if ( boot_cpu_data.x86_vendor & (X86_VENDOR_INTEL | X86_VENDOR_CENTAUR) )
> +    if ( boot_cpu_data.x86_vendor &
> +        (X86_VENDOR_INTEL | X86_VENDOR_CENTAUR | X86_VENDOR_SHANGHAI) )
>      {
>          /* SYSENTER entry. */
>          wrmsrl(MSR_IA32_SYSENTER_ESP, stack_bottom);

How is this hunk related to the title of the change? I think the
title wants to be adjusted.

Furthermore for all of the changes done, wouldn't we better
switch to use cpu_has_sep? init_amd() as well as default_init()
already clear this flag. Andrew, thoughts?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel