Re: [Xen-devel] [PATCH] xen/arm: Blacklist PMU with "arm, cortex-a53-pmu"

[Julien Grall <julien.grall@xxxxxxx>]

On 26/04/2019 12:58, Amit Tomer wrote:
> Hello,
Hi,

> > Could we instead try to automatically blacklist any device using PPI?
> Just tested following change:
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index d983677..0c82976 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1289,6 +1289,10 @@ static int __init handle_device(struct domain
> *d, struct dt_device_node *dev,
>               return res;
>           }
>
> +        /* Don't process device using PPI source */
> +        if ( res > 16 && res < 32)
> +            return 0;
> +
>           res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev));
>           if ( res )
>               return res;
>
> Would it be Ok ?
Well, this does not work properly. The DT node will still be written in the 
domain because handle_device() return 0. However, the device will be half mapped 
resulting to crash later on.
The proper way is to detect PPI before hand and completely skip the node if any.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel