Re: [Xen-devel] [PATCH v3 3/4] x86/mem_sharing: enable mem_share audit mode only in debug builds

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Mon, Apr 29, 2019 at 8:57 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
> >>> On 26.04.19 at 19:21, <tamas@xxxxxxxxxxxxx> wrote:
> > --- a/xen/include/asm-x86/mem_sharing.h
> > +++ b/xen/include/asm-x86/mem_sharing.h
> > @@ -25,7 +25,9 @@
> >  #include <public/memory.h>
> >
> >  /* Auditing of memory sharing code? */
> > +#ifndef NDEBUG
> >  #define MEM_SHARING_AUDIT 1
> > +#endif
>
> Since consumers use #if (not #ifdef), I think an #else would
> be on order here, even if (I think) not strictly necessary with
> gcc.

Sure.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel