Re: [Xen-devel] [PATCH v3 1/4] x86/mem_sharing: reorder when pages are unlocked and released

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.04.19 at 18:05, <tamas@xxxxxxxxxxxxx> wrote:
> On Mon, Apr 29, 2019 at 9:52 AM George Dunlap <george.dunlap@xxxxxxxxxx> 
> wrote:
>> I haven't re-grokked the code here, but assuming I was correct 2 weeks
>> ago, if you have the BUG_ON() there, you can get rid of the extra
>> references.
> 
> Sure, but again, the overhead of having them in-place is negligible so
> might as well just keep it.

The overhead is only one aspect here. People looking at the code
may also be mislead into trying to figure out why the heck this
extra reference gets obtained. Plus sub-optimal code tends to get
cloned ...

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel