Re: [Xen-devel] linux 4.19 does not build on armhf Re: [linux-4.19 test] 135420: regressions - FAIL

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.04.19 at 14:44, <ian.jackson@xxxxxxxxxx> wrote:
> osstest service owner writes ("[linux-4.19 test] 135420: regressions - FAIL"):
>> flight 135420 linux-4.19 real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/135420/ 
>> 
>> Regressions :-(
>> 
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>>  build-armhf-pvops             6 kernel-build             fail REGR. vs. 
>> 129313
> 
> http://logs.test-lab.xenproject.org/osstest/logs/135420/build-armhf-pvops/6.ts-kernel-build.log
> 
>   drivers/firmware/qcom_scm.c: In function ‘qcom_scm_assign_mem’:
>   drivers/firmware/qcom_scm.c:469:47: error: passing argument 3 of 
> ‘dma_alloc_coherent’ from incompatible pointer type 
> [-Werror=incompatible-pointer-types]
>     ptr = dma_alloc_coherent(__scm->dev, ptr_sz, &ptr_phys, GFP_KERNEL);
>                                                  ^
>   In file included from drivers/firmware/qcom_scm.c:21:0:
>   ./include/linux/dma-mapping.h:560:21: note: expected ‘dma_addr_t * {aka 
> long long unsigned int *}’ but argument is of type ‘phys_addr_t * {aka 
> unsigned int *}’
>    static inline void *dma_alloc_coherent(struct device *dev, size_t size,
>                        ^~~~~~~~~~~~~~~~~~
>   cc1: some warnings being treated as errors

The code is still the same in 5.1-rc7, so presumably the problem went
unnoticed till now. While it looks like it's straightforward to fix (thanks
to the 32-bit variant of __qcom_scm_assign_mem() doing nothing
with the passed in values, so it being "fine" for them to get truncated
during the call) the aspect that puzzles me is - where does this
-Werror=incompatible-pointer-types come from? Was the prior gcc
version indeed 4.9.x or older (which seems pretty old to me)? The
specific warning control (which Linux converts to an error) was
introduced for gcc 5.x.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel