Re: [Xen-devel] [RFC PATCH 2/7] x86/boot: Remove gratuitous call back into low-memory code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.05.19 at 13:17, <dwmw2@xxxxxxxxxxxxx> wrote:
> We appear to have implemented a memcpy() in the low-memory trampoline
> which we then call into from __start_xen(), for no adequately defined
> reason.

May I suggest that in cases like this you look at the commit
introducing the function? It supplies a reason:

"Add a new raw e820 table for common purpose and copy the BIOS buffer
 to it. Doing the copying in assembly avoids the need to export the
 symbols for the BIOS E820 buffer and number of entries."

I have to admit that I see value in this, as it avoids introduction
of wrong accesses to these variables. Therefore I'd like to ask
for better justification of the change.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel