Re: [Xen-devel] [PATCH v2] x86/vmx: correctly gather gs_shadow value for current vCPU

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 5/2/19 11:36 AM, Jan Beulich wrote:
> > > > On 02.05.19 at 08:20, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> > On 5/2/19 2:52 AM, Tamas K Lengyel wrote:
> > > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > > @@ -779,12 +779,17 @@ static void vmx_load_cpu_state(struct vcpu *v, struct 
> > > hvm_hw_cpu *data)
> > >   
> > >   static void vmx_save_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
> > >   {
> > > +    if ( v == current )
> > > +        vmx_save_guest_msrs(v);
> > vmx_save_guest_msrs() is simple enough that the if is probably not
> > necessary here (we can just call the function directly, regardless of
> > what v holds).
> Avoiding an MSR access is perhaps worth the conditional.
Fair enough.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel