|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [qemu-upstream-4.11-testing bisection] complete test-arm64-arm64-libvirt-xsm
branch xen-4.11-testing xenbranch xen-4.11-testing job test-arm64-arm64-libvirt-xsm testid xen-boot Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_gnulib https://git.savannah.gnu.org/git/gnulib.git/ Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: e202feb7131e66ed9186ad8766c9582502c98998 Bug not present: 198672807ec6c6a1dee07841433a3064cb446a89 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/135626/ commit e202feb7131e66ed9186ad8766c9582502c98998 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Date: Fri Feb 1 11:34:35 2019 +0100 xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct When the command line parsing was updated to use const strings and no longer tokenise with NUL characters, string matches could no longer be made with strcmp(). Unfortunately, the replacement was buggy. strncmp(s, "opt", ss - s) matches "o", "op" and "opt" on the command line, as ss - s may be shorter than the passed literal. Furthermore, parse_bool() is affected by this, so substrings such as "d", "e" and "o" are considered valid, with the latter being ambiguous between "on" and "off". Introduce a new strcmp-like function for the task, which looks for exact string matches, but declares success when the NUL of the literal matches a comma, colon or semicolon in the command line fragment. No change to the intended parsing functionality, but fixes cases where a partial string on the command line will inadvertently trigger options. A few areas were more than just a trivial change: * parse_irq_vector_map_param() gained some style corrections. * parse_vpmu_params() was rewritten to use the normal list-of-options form, rather than just fixing up parse_vpmu_param() and leaving the parsing being hard to follow. * Instead of making the trivial fix of adding an explicit length check in parse_bool(), use the length to select which token to we search for, which is more efficient than the previous linear search over all possible tokens. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Julien Grall <julien.grall@xxxxxxx> master commit: 2ddf7e3e341df3ccf21613ff7ffd4b7693abe9e9 master date: 2019-01-15 12:58:34 +0000 For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-upstream-4.11-testing/test-arm64-arm64-libvirt-xsm.xen-boot.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-upstream-4.11-testing/test-arm64-arm64-libvirt-xsm.xen-boot --summary-out=tmp/135626.bisection-summary --basis-template=125575 --blessings=real,real-bisect qemu-upstream-4.11-testing test-arm64-arm64-libvirt-xsm xen-boot Searching for failure / basis pass: 135446 fail [host=rochester0] / 125575 [host=laxton1] 125534 [host=laxton1] 125508 [host=laxton1] 125465 [host=laxton1] 125345 [host=laxton0] 125273 [host=laxton1] template as basis? using template as basis. Failure / basis pass flights: 135446 / 125575 (tree in latest but not in basispass: ovmf) Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_gnulib https://git.savannah.gnu.org/git/gnulib.git/ Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 e64ac26749dc2c0f390caccd04274608ab31c8cf c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 348922b16a0901ccc7b8980c92703b2ce20d1a2d Basis pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 1fd87ba1cd0312b743a48756a91c6962b1514aac Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#076a2b409667dd9f716a2a2085e1ffea9d58fe8b-076a2b409667dd9f716a2a2085e1ffea9d58fe8b https://git.savannah.gnu.org/git/gnulib.git/#d6397dde2e127e246e3eeb5254a21f42cac783c8-d6397dde2e127e246e3eeb5254a21f42cac783c8 https://gitlab.com/keycodemap/keycodemapdb.git#16e5b0787687d8904dad2c026107409eb9bfcb95-16e5b0787687d8904dad2c026107409eb9bfcb95 git://xenbits.xen.org/linux-pvops.git#50484ee133c2219a26fd98b39770187221b5\ e0bc-e64ac26749dc2c0f390caccd04274608ab31c8cf git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen.git#20c76f9a5fbf16d58c6add2ace2ff0fabd785926-2871355a6957f1b3c16f858e3143e0fff0737b6a git://xenbits.xen.org/xen.git#1fd87ba1cd0312b743a48756a91c6962b1514aac-348922b16a0901ccc7b8980c92703b2ce20d1a2d adhoc-revtuple-generator: tree discontiguous: linux-pvops Loaded 2011 nodes in revision graph Searching for test results: 125273 [host=laxton1] 125345 [host=laxton0] 125465 [host=laxton1] 125534 [host=laxton1] 125508 [host=laxton1] 125575 [host=laxton1] 134697 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 718a8d2e9cbacb14f86f6dee40732727cd79bcff 134815 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 718a8d2e9cbacb14f86f6dee40732727cd79bcff 135029 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 e64ac26749dc2c0f390caccd04274608ab31c8cf c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 718a8d2e9cbacb14f86f6dee40732727cd79bcff 134961 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 718a8d2e9cbacb14f86f6dee40732727cd79bcff 135205 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 e64ac26749dc2c0f390caccd04274608ab31c8cf c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 348922b16a0901ccc7b8980c92703b2ce20d1a2d 135446 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 e64ac26749dc2c0f390caccd04274608ab31c8cf c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 348922b16a0901ccc7b8980c92703b2ce20d1a2d 135418 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 e64ac26749dc2c0f390caccd04274608ab31c8cf c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 348922b16a0901ccc7b8980c92703b2ce20d1a2d 135534 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 e64ac26749dc2c0f390caccd04274608ab31c8cf c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 348922b16a0901ccc7b8980c92703b2ce20d1a2d 135512 pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 1fd87ba1cd0312b743a48756a91c6962b1514aac 135519 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 e64ac26749dc2c0f390caccd04274608ab31c8cf c530a75c1e6a472b0eb9558310b518f0dfcd8860 2871355a6957f1b3c16f858e3143e0fff0737b6a 348922b16a0901ccc7b8980c92703b2ce20d1a2d 135528 pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 1fd87ba1cd0312b743a48756a91c6962b1514aac 135556 pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 14b7dc115b8a5d90cf842ac003100542408f671c 135602 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 514dccd049f8338495b6c992b9c6a1ec2ece2932 135541 pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 ff9f8730a993b0ffac06af28af0b0132e1f123fe 135607 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 e202feb7131e66ed9186ad8766c9582502c98998 135569 pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 63d71138a4d3521cf42ff28b0dd3e79b82d79230 135548 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 dd492b8f64d9ad9d413289565bd074f025f8edde 135576 pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 198672807ec6c6a1dee07841433a3064cb446a89 135614 pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 198672807ec6c6a1dee07841433a3064cb446a89 135620 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 e202feb7131e66ed9186ad8766c9582502c98998 135623 pass 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 198672807ec6c6a1dee07841433a3064cb446a89 135626 fail 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 e202feb7131e66ed9186ad8766c9582502c98998 Searching for interesting versions Result found: flight 135512 (pass), for basis pass Result found: flight 135519 (fail), for basis failure Repro found: flight 135528 (pass), for basis pass Repro found: flight 135534 (fail), for basis failure 0 revisions at 076a2b409667dd9f716a2a2085e1ffea9d58fe8b d6397dde2e127e246e3eeb5254a21f42cac783c8 16e5b0787687d8904dad2c026107409eb9bfcb95 50484ee133c2219a26fd98b39770187221b5e0bc c530a75c1e6a472b0eb9558310b518f0dfcd8860 20c76f9a5fbf16d58c6add2ace2ff0fabd785926 198672807ec6c6a1dee07841433a3064cb446a89 No revisions left to test, checking graph state. Result found: flight 135576 (pass), for last pass Result found: flight 135607 (fail), for first failure Repro found: flight 135614 (pass), for last pass Repro found: flight 135620 (fail), for first failure Repro found: flight 135623 (pass), for last pass Repro found: flight 135626 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: e202feb7131e66ed9186ad8766c9582502c98998 Bug not present: 198672807ec6c6a1dee07841433a3064cb446a89 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/135626/ commit e202feb7131e66ed9186ad8766c9582502c98998 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Date: Fri Feb 1 11:34:35 2019 +0100 xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct When the command line parsing was updated to use const strings and no longer tokenise with NUL characters, string matches could no longer be made with strcmp(). Unfortunately, the replacement was buggy. strncmp(s, "opt", ss - s) matches "o", "op" and "opt" on the command line, as ss - s may be shorter than the passed literal. Furthermore, parse_bool() is affected by this, so substrings such as "d", "e" and "o" are considered valid, with the latter being ambiguous between "on" and "off". Introduce a new strcmp-like function for the task, which looks for exact string matches, but declares success when the NUL of the literal matches a comma, colon or semicolon in the command line fragment. No change to the intended parsing functionality, but fixes cases where a partial string on the command line will inadvertently trigger options. A few areas were more than just a trivial change: * parse_irq_vector_map_param() gained some style corrections. * parse_vpmu_params() was rewritten to use the normal list-of-options form, rather than just fixing up parse_vpmu_param() and leaving the parsing being hard to follow. * Instead of making the trivial fix of adding an explicit length check in parse_bool(), use the length to select which token to we search for, which is more efficient than the previous linear search over all possible tokens. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Julien Grall <julien.grall@xxxxxxx> master commit: 2ddf7e3e341df3ccf21613ff7ffd4b7693abe9e9 master date: 2019-01-15 12:58:34 +0000 Revision graph left in /home/logs/results/bisect/qemu-upstream-4.11-testing/test-arm64-arm64-libvirt-xsm.xen-boot.{dot,ps,png,html,svg}. ---------------------------------------- 135626: tolerable FAIL flight 135626 qemu-upstream-4.11-testing real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/135626/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-arm64-arm64-libvirt-xsm 7 xen-boot fail baseline untested jobs: build-arm64-libvirt pass test-arm64-arm64-libvirt-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |