Re: [Xen-devel] [PATCH 8/9] x86/IRQ: make fixup_irqs() skip unconnected internally used interrupts

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Apr 29, 2019 at 05:26:41AM -0600, Jan Beulich wrote:
> Since the "Cannot set affinity ..." warning is a one time one, avoid
> triggering it already at boot time when parking secondary threads and
> the serial console uses a (still unconnected at that time) PCI IRQ.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -2412,8 +2412,20 @@ void fixup_irqs(const cpumask_t *mask, b
>          vector = irq_to_vector(irq);
>          if ( vector >= FIRST_HIPRIORITY_VECTOR &&
>               vector <= LAST_HIPRIORITY_VECTOR )
> +        {
>              cpumask_and(desc->arch.cpu_mask, desc->arch.cpu_mask, mask);
>  
> +            /*
> +             * This can in particular happen when parking secondary threads
> +             * during boot and when the serial console wants to use a PCI 
> IRQ.
> +             */
> +            if ( desc->handler == &no_irq_type )

I found it weird that a irq has a vector assigned (in this case a
high-priority vector) but no irq type set.

Shouldn't the vector be assigned when the type is set?

> +            {
> +                spin_unlock(&desc->lock);
> +                continue;
> +            }
> +        }
> +
>          if ( desc->arch.move_cleanup_count )
>          {
>              /* The cleanup IPI may have got sent while we were still online. 
> */

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel