Re: [Xen-devel] [PATCH] mm: option to _always_ scrub freed domheap pages

["Elnikety, Eslam" <elnikety@xxxxxxxxxx>]

> On 7. May 2019, at 12:06, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
>>>> On 07.05.19 at 12:03, <JBeulich@xxxxxxxx> wrote:
>>>>> On 07.05.19 at 11:55, <george.dunlap@xxxxxxxxxx> wrote:
>>> On 5/6/19 1:46 PM, Eslam Elnikety wrote:
>>>> --- a/xen/common/page_alloc.c
>>>> +++ b/xen/common/page_alloc.c
>>>> @@ -214,6 +214,12 @@ custom_param("bootscrub", parse_bootscrub_param);
>>>> static unsigned long __initdata opt_bootscrub_chunk = MB(128);
>>>> size_param("bootscrub_chunk", opt_bootscrub_chunk);
>>>> 
>>>> +/*
>>>> + * scrub_domheap -> Domheap pages are scrubbed when freed
>>>> + */
>>>> +static bool_t opt_scrub_domheap = 0;
>>>> +boolean_param("scrub_domheap", opt_scrub_domheap);
>>> 
>>> I'm sure Jan will request this to be 'scrub-domheap' instead (not using
>>> '_' when you can use '-').
>> 
>> Indeed, plus use "bool", drop the pointless initializer, and correct
>> the style of the (single line) comment.
> 
> And use __read_mostly.
> 
> Jan
> 
> 

Thanks for all the comments on this thread. v2 should take care of all those 
comments.

Cheers,
Eslam
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel