[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] libxl: make vkbd tunable for HVM guests
On 07.05.19, 15:17, "Wei Liu" <wei.liu2@xxxxxxxxxx> wrote: On Tue, May 07, 2019 at 08:35:48AM +0000, Eslam Elnikety wrote: > Each HVM guest currently gets a vkbd frontend/backend pair (c/s ebbd2561b4c). > This consumes host resources unnecessarily for guests that have no use for > vkbd. Make this behaviour tunable to allow an administrator to choose. The > commit retains the current behaviour -- HVM guests still get vkdb unless > specified otherwise. > > Signed-off-by: Eslam Elnikety <elnikety@xxxxxxxxxx> Who / what is to set this field? It appears this patch only contains one change to xl to print out its value. Missed a hunk when preparing the patch. Sending v2 now .. > --- > tools/libxl/libxl_create.c | 9 ++++++--- > tools/libxl/libxl_types.idl | 1 + > tools/xl/xl_sxp.c | 2 ++ > 3 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index 89fe80fc9c..b09244058f 100644 > --- a/tools/libxl/libxl_create.c > +++ b/tools/libxl/libxl_create.c > @@ -310,6 +310,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, > libxl_defbool_setdefault(&b_info->u.hvm.vpt_align, true); > libxl_defbool_setdefault(&b_info->u.hvm.altp2m, false); > libxl_defbool_setdefault(&b_info->u.hvm.usb, false); > + libxl_defbool_setdefault(&b_info->u.hvm.vkb_device, true); > libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true); > > libxl_defbool_setdefault(&b_info->u.hvm.spice.enable, false); > @@ -1416,9 +1417,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, > libxl__device_console_add(gc, domid, &console, state, &device); > libxl__device_console_dispose(&console); > > - libxl_device_vkb_init(&vkb); > - libxl__device_add(gc, domid, &libxl__vkb_devtype, &vkb); > - libxl_device_vkb_dispose(&vkb); > + if ( libxl_defbool_val(d_config->b_info.u.hvm.vkb_device) ) { No space inside if() please. Yup -- Will fix in v2. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |