Re: [Xen-devel] [PATCH] x86/mm: subsume set_gpfn_from_mfn() into guest_physmap_add_entry()

[Julien Grall <julien.grall@xxxxxxx>]

Hi Jan,

On 5/2/19 7:58 AM, Jan Beulich wrote:
> This is what both callers of guest_physmap_add_page() in memory.c want
> (for the !paging_mode_translate() case), and it is also what both
> callers in gnttab_transfer() need (but have been lacking). The other
> (x86-specific) callers are all HVM-only, and hence unaffected by this
> change.
>
> Sadly this isn't enough yet to drop Arm's dummy macro, as there's one
> more use in page_alloc.c.
I think we can live with that. I have now sent a patch to move the dummy 
implementation in common code (see 
<20190507151458.29350-15-julien.grall@xxxxxxx>).
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
The common code looks fine to me. I will leave Andrew commenting for the 
x86 parts:
Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel