[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] MAINTAINERS: Add explicit check-in policy section



>>> On 09.05.19 at 13:05, <ian.jackson@xxxxxxxxxx> wrote:
> George Dunlap writes ("Re: [Xen-devel] [PATCH] MAINTAINERS: Add explicit 
> check-in policy section"):
>> On 5/8/19 12:59 PM, Juergen Gross wrote:
>> > 2. In the case the submitter is a maintainer of a modified file it must
>> > have an Ack or Review from either a "nested" maintainer or a Designated
>> > reviewer of that file.
>> 
>> That changes the current meaning of "Designated Reviewer" somewhat.  At
>> the moment, it only means "Send this person an email"; if we did that,
>> it would mean, "This person is more trusted to do reviews than others".
>> 
>> Not sure what I think about that yet.
> 
> I think this is a bad idea.  The purpose was to provide a way for
> someone to be emailed which doesn't involve giving them authority,
> and which is therefore a status which can be granted on request and
> does not require any assessment etc.
> 
> If we chane this we will have to invent a new status to perform this
> function.

I think we will want to do this anyway: "Designated Reviewer" isn't
the same as "Cc <person> on patches" (which may be just because
someone wants to monitor what's being submitted / discussed). At
least that's my (non-native-English) understanding of "designated".

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.