Re: [Xen-devel] [PATCH 09/14] xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 9 May 2019, Julien Grall wrote:
> Hi Stefano,
> 
> On 5/9/19 7:16 PM, Stefano Stabellini wrote:
> > On Thu, 9 May 2019, Julien Grall wrote:
> > > Hi,
> > > 
> > > On 5/9/19 7:06 PM, Stefano Stabellini wrote:
> > > > On Tue, 7 May 2019, Julien Grall wrote:
> > > > > diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> > > > > index d1bfc82f57..f1761fe183 100644
> > > > > --- a/xen/include/xen/domain.h
> > > > > +++ b/xen/include/xen/domain.h
> > > > > @@ -118,4 +118,12 @@ struct vnuma_info {
> > > > >      void vnuma_destroy(struct vnuma_info *vnuma);
> > > > >    +#ifdef CONFIG_HAS_M2P
> > > > > +#define domain_shared_info_gfn(d) ({                            \
> > > > > +    const struct domain *d_ = (d);                              \
> > > > > +                                                                \
> > > > > +    mfn_to_gfn(d_, _mfn(__virt_to_mfn(d_->shared_info)));       \
> > > > 
> > > > Aren't you missing a _gfn here?
> > > > 
> > > >     _gfn(mfn_to_gfn(d, _mfn(__virt_to_mfn(d->shared_info))));
> > > 
> > > Patch #3 of this series convert mfn_to_gfn to use typesafe MFN & GFN. So
> > > the
> > > function now return a gfn_t.
> > 
> > Ah! Somehow I am missing patches 2-3-4 in my inbox. I'll try to get them
> > from the archive.
> 
> Because they are x86 specific :). The rationale of implementing
> domain_shared_info_gfn() in common code is any arch using M2P should provide a
> similar helper.
> 
> Arm doesn't have an M2P, hence why mfn_to_gfn is not existent.

All right. Add my acked-by to this patch.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel