Re: [Xen-devel] [PATCH v2 6/7] xen/arm: tlbflush: Rework TLB helpers

[Julien Grall <Julien.Grall@xxxxxxx>]

On 09/05/2019 21:32, Stefano Stabellini wrote:
> On Wed, 8 May 2019, Julien Grall wrote:
> I agree with what you are trying to achieve with this patch and I like
> the idea of reducing code duplication. As I look at the code, I was
> hoping to find a way to avoid introducing macros and use static inline
> functions instead, but it doesn't look like it is possible for arm32.
> There is no way to pass TLBIALLIS as a parameter to a function for
> instance. It might be possible for arm64 as they are just strings, but at
> that point it might be better to keep the code similar between arm32 and
> arm64 having both of them as macros, instead of having one as macro and
> the other as static inline.
> 
> Do you agree with me? Can you see any other ways to turn TLB_HELPER into
> a static inline?

I really can't see how you can even turn the arm64 version as a static 
inline... Even if TLBIALLIS is a string, we are using it to generate the 
assembly. Without the help of the pre-processor, you would have to look 
at the string and generate the associated operation.

So there are no way you can do the same with static inline unless you 
duplicate all the helpers. But this would defeat the purpose of this patch.

Cheers,

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel