Re: [Xen-devel] [PATCH 1/5] pci: use pci_sbdf_t in pci_dev

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.05.19 at 18:16, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 10/05/2019 17:10, Roger Pau Monne wrote:
>> --- a/xen/arch/x86/hvm/vmsi.c
>> +++ b/xen/arch/x86/hvm/vmsi.c
>> @@ -688,8 +688,8 @@ static int vpci_msi_update(const struct pci_dev *pdev, 
>> uint32_t data,
>>          {
>>              gdprintk(XENLOG_ERR,
>>                       "%04x:%02x:%02x.%u: failed to bind PIRQ %u: %d\n",
>> -                     pdev->seg, pdev->bus, PCI_SLOT(pdev->devfn),
>> -                     PCI_FUNC(pdev->devfn), pirq + i, rc);
>> +                     pdev->sbdf.seg, pdev->sbdf.bus, pdev->sbdf.dev,
>> +                     pdev->sbdf.func, pirq + i, rc);
> 
> A pci_sbdf_t is 32 bits wide.  I do actually have a custom %p formatter
> from a year or so ago, which simplifies code like this substantially.
> 
> Is there any interest in dusting off that patch and folding it into this
> cleanup series?  ISTR it also came with several corrections to existing
> SBDF rendering.

Afaic: Yes please! The one thing I'm not sure about is whether this
should be PCI-specific, or whether it wouldn't better be a more
general device thing. But I guess we use SBDF also independent of
struct pci_dev.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel