Re: [Xen-devel] Xen GCC coverage ARM64 testing - Unexpected Trap: Data Abort

[Viktor Mitin <viktor.mitin.19@xxxxxxxxx>]

Hi Julien,

Please be aware that the patch you proposed (+nocov-y += libfdt.o)
failed to build with the next error (xen 4.12):

aarch64-poky-linux-gcc   -DBUILD_ID -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2
-fomit-frame-pointer
-D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
.handlereg.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -Werror
-Wmissing-prototypes -I./include
-I/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/git/tools/libs/toolcore/../../../tools/include
 -c -o handlereg.o handlereg.c
aarch64-poky-linux-gcc  -DPIC  -DBUILD_ID -fno-strict-aliasing
-std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2
-fomit-frame-pointer
-D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
.handlereg.opic.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -Werror
-Wmissing-prototypes -I./include
-I/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/git/tools/libs/toolcore/../../../tools/include
 -fPIC -c -o handlereg.opic handlereg.c
mkdir -p 
/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/git/tools/pkg-config
In file included from ./include/xentoolcore.h:25:0,
                 from ./include/xentoolcore_internal.h:29,
                 from handlereg.c:23:
/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/recipe-sysroot-native/usr/lib/aarch64-poky-linux/gcc/aarch64-poky-linux/7.2.1/include/stdint.h:9:16:
fatal error: stdint.h: No such file or directory
 # include_next <stdint.h>
                ^~~~~~~~~~
compilation terminated.
In file included from include/xentoolcore.h:25:0,
                 from include/xentoolcore_internal.h:29:
/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/recipe-sysroot-native/usr/lib/aarch64-poky-linux/gcc/aarch64-poky-linux/7.2.1/include/stdint.h:9:16:
fatal error: stdint.h: No such file or directory
 # include_next <stdint.h>
                ^~~~~~~~~~
compilation terminated.
/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/git/tools/libs/toolcore/../../../tools/Rules.mk:227:
recipe for target 'handlereg.o' failed
make[7]: *** [handlereg.o] Error 1
make[7]: *** Waiting for unfinished jobs....
/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/git/tools/libs/toolcore/../../../tools/Rules.mk:238:
recipe for target 'headers.chk' failed
make[7]: *** [headers.chk] Error 1
In file included from ./include/xentoolcore.h:25:0,
                 from ./include/xentoolcore_internal.h:29,
                 from handlereg.c:23:
/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/recipe-sysroot-native/usr/lib/aarch64-poky-linux/gcc/aarch64-poky-linux/7.2.1/include/stdint.h:9:16:
fatal error: stdint.h: No such file or directory
 # include_next <stdint.h>
                ^~~~~~~~~~
compilation terminated.


Thanks

On Fri, May 3, 2019 at 5:19 PM Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
>
> On Fri, May 03, 2019 at 03:16:52PM +0100, Julien Grall wrote:
> > > > diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile
> > > > index d81f54b6b8..c075bbf546 100644
> > > > --- a/xen/common/libfdt/Makefile
> > > > +++ b/xen/common/libfdt/Makefile
> > > > @@ -3,6 +3,7 @@ include Makefile.libfdt
> > > >   SECTIONS := text data $(SPECIAL_DATA_SECTIONS)
> > > >
> > > >   obj-y += libfdt.o
> > > > +nocov-y += libfdt.o
> > > >
> > > >   CFLAGS += -I$(BASEDIR)/include/xen/libfdt/
> > > >
> > > > While looking at the code, I noticed libelf is also built with coverage 
> > > > but
> > > > in .init section. So I would expect the same error on x86, did you try
> > > > "xencov reset" on x86?
> > >
> > > I did. It worked. Though at this point I'm not sure why it worked. :-/
> >
> > I think I know why, only the sections .text and .data are prefixed with
> > .init. In the case of libelf, none of the GCOV symbols seems to be located
> > in .data.
> >
> > For libfdt, some of them are located in .data (renamed to .init.data). Hence
> > the difference in behavior.
> >
>
> Thanks for the analysis.
>
> > We should probably fixed the two libraries as this is quite fragile for
> > libelf as well.
>
> Sounds good to me.
>
> Wei.
>
> >
> > Cheers,
> >
> > --
> > Julien Grall
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxxx
> > https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel