Re: [Xen-devel] [PATCH 1/4] xen/watchdog: Fold exit paths to have a single unlock

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.05.19 at 15:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 13/05/2019 14:47, Jan Beulich wrote:
>>>>> On 10.05.19 at 20:28, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> --- a/xen/common/schedule.c
>>> +++ b/xen/common/schedule.c
>>> @@ -1050,6 +1050,8 @@ static void domain_watchdog_timeout(void *data)
>>>  
>>>  static long domain_watchdog(struct domain *d, uint32_t id, uint32_t 
>>> timeout)
>>>  {
>>> +    long rc = 0;
>> I'm wondering why this isn't plain int. Not a big deal, but I'm
>> curious anyway.
> 
> To match the return value.

But the compiler will happily sign-extend the value at the return statement.

>  This function is compiled twice AFAICT.

I have no idea how this matters.

>> As per your own response to patch 2 I understand that the
>> other patches in this series don#t need looking at until you
>> send a v2.
> 
> patch 3 is independent of the ABI changes, so fine in principle to
> review now.

Okay.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel