Re: [Xen-devel] [PATCH v1] libxl: add helper function to set device_model_version

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 14, 2019 at 12:39:07PM +0200, Roger Pau Monné wrote:
> On Tue, May 14, 2019 at 12:31:18PM +0200, Olaf Hering wrote:
> > Am Tue, 14 May 2019 12:18:56 +0200
> > schrieb Roger Pau Monné <roger.pau@xxxxxxxxxx>:
> > 
> > > Why is it not fine to set the device model version in
> > > libxl__domain_build_info_setdefault?
> > 
> > Because it receives just build_info, which lacks all the data to decide
> > if a device type needs a device model or not.
> 
> Gah, thanks. Could you please add this to the commit message? Or else
> it's likely I will ask again.
> 
> With that:
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Olaf, if you can provide me with an updated version of the commit
message I can fold that in while committing. No need to resend this
patch.

Wei.

> 
> Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel