[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] page-alloc: accompany BUG() with printk()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 15 May 2019 12:09:01 +0200
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@xxxxxxxxxx; spf=SoftFail smtp.mailfrom=roger.pau@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxxxxxxxxxxxxx
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 15 May 2019 10:09:18 +0000
- Ironport-sdr: g3A1nTekBgfIeEbEEgx3LJdwm4FWakuXKyPi6KdbiaquHiS3t9Ij6dg8jFXTcYtrH1QRJ6L8yv 59YIPfA1rRVcHt8kdKpOzbNDLx4OzcYsOUcPKCi8X/155Drd/+f7uPsDDlh43U0V2TbvU3fMLq Uu2ALZtCRvtYtu5Z4Ud+7FKwLxNZBlhTa/PkXHzi5kYXMMY3ia6RVDdbfdXxew9fL6Xqz7PG1N Q/w6Pn6PERzqWC1vnvENV05ZddJYREjAbVGY8kZSCw/ra/xmUOJcF6nHh+tEWi0Sva8P62EtSY k9Y=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, May 15, 2019 at 10:59:20AM +0100, Andrew Cooper wrote:
> On 15/05/2019 10:44, Roger Pau Monné wrote:
> > On Wed, May 15, 2019 at 02:44:07AM -0600, Jan Beulich wrote:
> >> Log information likely relevant for understanding why the BUG()s were
> > Why not use panic instead of printk + BUG?
>
> Because the backtrace is useful a lot of the time.
Oh, panic has no backtrace, that's not very useful. Maybe we could add
a panic_trace version to avoid having to do a printk + BUG. In any
case:
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
