Re: [Xen-devel] [PATCH v2 01/10] xen: add a p2mt parameter to map_mmio_regions

[Oleksandr <olekstysh@xxxxxxxxx>]

On 01.05.19 00:02, Stefano Stabellini wrote:

Hi, Stefano

> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
> index efb6ca9..6adfa55 100644
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -52,7 +52,8 @@ static int map_range(unsigned long s, unsigned long e, void 
> *data,
>            * - {un}map_mmio_regions doesn't support preemption.
>            */
>   
> -        rc = map->map ? map_mmio_regions(map->d, _gfn(s), size, _mfn(s))
> +        rc = map->map ? map_mmio_regions(map->d, _gfn(s), size, _mfn(s),
> +                                         p2m_mmio_direct)
Not really sure the VPCI is used on ARM, but xen/drivers/vpci/ looks 
like a common code.
But, according to the commit description, we should pass 
"p2m_mmio_direct" on x86 and "p2m_mmio_direct_dev" on ARM...
>                         : unmap_mmio_regions(map->d, _gfn(s), size, _mfn(s));
>           if ( rc == 0 )
>           {
> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
--
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel