[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs

On Thu, May 16, 2019 at 11:26 PM Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >>> On 16.05.19 at 21:30, <alistair23@xxxxxxxxx> wrote:
> > On Thu, May 16, 2019 at 3:32 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >>
> >> >>> On 16.05.19 at 02:02, <alistair.francis@xxxxxxx> wrote:
> >> > Make the asm/vpl011.h dependent on the ARM architecture.
> >>
> >> But we only have x86 and Arm right now. A word more about
> >> your motivation would help.
> >
> > As the code currently is no one can add another architecture. This is
> > just a general fixup as assuming Xen will only ever support two archs
> > seems strange.
> But that's then not the only place, is it? I'd not expect a single,
> random change of this kind to be sent all on its own in such a
> case.

This is the only case that I have run into where there isn't a sane
#else condition. Most other #ifdefs fall through to an "Unsupported.."
message in the #else.

> >> Also I don't think your Cc list is wide enough for this change.
> >
> > I couldn't find anyother people in the MAINTAINERS file, who else should I
> > CC?
> Well, how did you land at Cc-ing the tool stack maintainers on
> this hypervisor change? Anyway - there's a section THE REST
> at the bottom of ./MAINTAINERS, and we also have the two
> scripts/*_maintainers.pl scripts to aid you with determining
> who to Cc.

Ah, sorry. I just grepped the file next time I'll make sure to turn the script.


> Jan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.