Re: [Xen-devel] [PATCH v2 4/7] xen/arm: page: Clarify the Xen TLBs helpers name

[Julien Grall <Julien.Grall@xxxxxxx>]

On 20/05/2019 22:01, Stefano Stabellini wrote:
> On Fri, 10 May 2019, Julien Grall wrote:
>> Feel free to suggest an in-code comment so we can discuss on the worthiness.
> 
> I suggest something like the following:
> 
>   /*
>    * Flush all hypervisor mappings from the TLB of the local processor. Note
>    * that instruction cache maintenance might also be required when self
>    * modifying Xen code, see D5-2522 in ARM DDI 0487D.a and B3.11.2 in ARM
>    * DDI 0406C.c.
>    */

This looks quite out-of-context, what is the relation between 
self-modifying code and TLB flush?

Cheers,

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel