Re: [Xen-devel] [PATCH MM-PART2 RESEND v2 12/19] xen/arm32: head: Always zero r3 before update a page-table entry

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

On 14.05.19 15:24, Julien Grall wrote:
> The boot code is using r2 and r3 to hold the page-table entry value.
> While r2 is always updated before storing the value, this is not always
> the case for r3.
>
> Thankfully today, r3 will always be zero when we care. But this is
> difficult to track and error-prone.
>
> So always zero r3 within the few instructions before the write the
> page-table entry.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
>
> ---
>      Changes in v2:
>          - Use 0x0 instead of 0
>          - Remove a duplicate mov r3, #0
> ---

Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>

--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel