Re: [Xen-devel] [PATCH v4 1/2] x86/emulate: Move hvmemul_linear_to_phys

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 5/22/19 2:13 PM, Paul Durrant wrote:
>> -----Original Message-----
>> From: Alexandru Stefan ISAILA [mailto:aisaila@xxxxxxxxxxxxxxx]
>> Sent: 20 May 2019 13:55
>> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
>> Cc: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; jbeulich@xxxxxxxx; Andrew Cooper
>> <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; Roger Pau Monne 
>> <roger.pau@xxxxxxxxxx>;
>> rcojocaru@xxxxxxxxxxxxxxx; tamas@xxxxxxxxxxxxx; George Dunlap 
>> <George.Dunlap@xxxxxxxxxx>; Alexandru
>> Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
>> Subject: [PATCH v4 1/2] x86/emulate: Move hvmemul_linear_to_phys
>>
>> Thiis is done so hvmemul_linear_to_phys() can be called from
>> hvmemul_send_vm_event().
>>
>> Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
>> ---
>>  xen/arch/x86/hvm/emulate.c | 181 ++++++++++++++++++-------------------
>>  1 file changed, 90 insertions(+), 91 deletions(-)
>>
>> diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
>> index 8659c89862..254ff6515d 100644
>> --- a/xen/arch/x86/hvm/emulate.c
>> +++ b/xen/arch/x86/hvm/emulate.c
>> @@ -530,6 +530,95 @@ static int hvmemul_do_mmio_addr(paddr_t mmio_gpa,
>>      return hvmemul_do_io_addr(1, mmio_gpa, reps, size, dir, df, ram_gpa);
>>  }
>>
> 
> I know this is code movement, but it would probably good to a do a bit of 
> tidying...

I think there are different minds on this; I *generally* prefer pure
code movement to be with as few changes as possible, to make sure actual
changes are easy to call out.

The changes you've asked for are pretty minor (and you're the maintainer
of the file it's being moved to), so I won't argue about it in this
particular case.  Just want to counter the idea that move + change is
the norm. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel