[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/6] osstest: introduce a helper to get the svn revision of a git commit


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Thu, 23 May 2019 11:03:52 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxxxxxxxxxxxxx
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 23 May 2019 10:04:32 +0000
  • Ironport-sdr: MZRXwCPaPjD0vdZdqYxAN01p3L8pAlLQLbRt/GCZ9UDexxUWlmy01GxAq0QlynsQZTGLs0OO7S w4NgH0Ybgz6ylv4XEQ5L7Cs9D6ydLZQk2ZJp2z/9jOVd9M87vd7jfk4+vA7yAAz/ReIcuexGeC ux+iFqygwaanLvgWB2N/TZUt7BcuIyMvEIikZAp4Ryo79sKRlGL7O4tiViz75YJPcdaW78aupI KkcBIhm7wPEiWwROD797f0tBrqHxKT5Q9Ox6l4F1lY7t7b+Cpp/VvQr8+jRsLdhTzzyiHI7YF2 k94=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Roger Pau Monne writes ("[Xen-devel] [PATCH 4/6] osstest: introduce a helper to 
get the svn revision of a git commit"):
> This only works when the svn revision is stored as a git note
> with the format 'revision=<revision number>'.

Wow.  This is pretty ugly.

> Such conversion is required in order to bootstrap a FreeBSD system
> without relying on external package repositories. FreeBSD base system
> only contains a subversion client (no git client), and thus in order
> to fetch the ports repository (that contain the external packages
> build makefiles) svn must be used.

git notes have some different way of travelling than commits, don't
they ?  Where is this git note coming from and how do we know it is
the right note, IYSWIM ?

Aside from that, please break the refactoring (in this case, the
breaking out of repo_get_realurl) into a separate NFC patch.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.