Re: [Xen-devel] [PATCH 1/4] x86/pv: Fix error handling in dom0_construct_pv()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.05.19 at 12:18, <andrew.cooper3@xxxxxxxxxx> wrote:
> One path in dom0_construct_pv() returns -1 unlike all other error paths.
> Switch it to returning -EINVAL.
> 
> This was last modified by c/s c84481fb XSA-55, but the bug predates that
> series.  However, this patch did (for no obvious reason) introduce a
> bifurcated tail to the function with two subtly different elf_check_broken()
> clauses.
> 
> As the elf_check_broken() is just a warning and doesn't influence the further
> boot, fold the exit paths together and use a single clause.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel