Re: [Xen-devel] [PATCH 3/4] x86/boot: Wire up dom0=shadow for PV dom0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.05.19 at 12:18, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -675,12 +675,16 @@ Controls for how dom0 is constructed on x86 systems.
>          selected mode.
>      *   For a PVH dom0, the hardware must have VT-x/SVM extensions 
> available.
>  
> -*   The `shadow` boolean is only applicable when dom0 is constructed as a PVH
> -    guest, and controls whether dom0 uses hardware assisted paging, or shadow
> -    paging.  The default is HAP when available, and shadow otherwise.
> +*   The `shadow` boolean allows dom0 to be explicitly constructed using 
> shadow
> +    paging.  This option is unavailable when `CONFIG_SHADOW_PAGING` is
> +    disabled.
>  
> -    This option is unavailable when `CONFIG_SHADOW_PAGING` is disabled.  Such
> -    builds of Xen require HAP-capable hardware to use a PVH dom0.
> +    For PVH, dom0 defaults to using HAP on capable hardware, and falls back 
> to
> +    shadow paging otherwise.  A PVH dom0 cannot be used if Xen is compiled
> +    without paging support, and the hardware lacks HAP support.

I think you want to add another "shadow" ahead of "paging" here.
Other than this
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel