Re: [Xen-devel] [PATCH v2] x86/altp2m: cleanup p2m_altp2m_lazy_copy

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Mon, May 27, 2019 at 9:55 AM George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
>
> On 4/12/19 9:08 PM, Tamas K Lengyel wrote:
> > The p2m_altp2m_lazy_copy is responsible for lazily populating an altp2m view
> > when the guest traps out due to no EPT entry being present in the active 
> > view.
> > Currently the function took several inputs that it didn't use and also
> > locked/unlocked gfns when it didn't need to.
>
> Wow, the code you're cleaning up was really all over the place.  Thanks
> for this.
>
> The code in your patch looks correct; but while you've gotten rid of the
> redundant host p2m lookup, there's still a redundant altp2m lookup.  Is
> there any reason not to take it to its logical conclusion, like the
> attached patch?

Looks good to me.

>
> NB this is compile-tested only; definitely double-check it for logic errors.

I did a live test and everything works fine.

Thanks,
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel